Skip to content

Abilities API: Make the ability category optional - #13157

Open
gziolo wants to merge 3 commits into
WordPress:trunkfrom
gziolo:ticket-65569
Open

Abilities API: Make the ability category optional#13157
gziolo wants to merge 3 commits into
WordPress:trunkfrom
gziolo:ticket-65569

Conversation

@gziolo

@gziolo gziolo commented Aug 19, 2026

Copy link
Copy Markdown
Member

This makes the category argument optional when registering an ability. When it is omitted, the registry assigns the built-in uncategorized category.

Previously, the registry only validated a category when one was provided, but WP_Ability still required the argument during instantiation. This left registrations without a category unable to succeed. Applying the fallback before validation keeps explicit invalid category values rejected while allowing simple or transitional registrations to omit a category.

The change:

  • registers the uncategorized category with the other core ability categories;
  • defaults an omitted category to uncategorized;
  • relies on the category lookup's string type declaration to reject invalid types;
  • requires provided category strings, including an empty string, to name a registered category;
  • updates the public API documentation; and
  • adds regression coverage for the fallback and invalid category values.

Props @Sachin7907 for the patch and @itzmekhokan for feedback.

Trac ticket: https://core.trac.wordpress.org/ticket/65569

Testing

  • git diff --check passes.
  • PHPCS passes for all changed PHP files.
  • wpAbilitiesRegistry.php: 37 tests, 71 assertions.
  • wpRegisterAbility.php: 20 tests, 50 assertions.
  • wpRegisterCoreAbilities.php: 14 tests, 131 assertions.

Use of AI Tools

AI assistance: Yes
Tool(s): OpenAI Codex
Model(s): GPT-5
Used for: Reviewing the existing local diff, running validation, and preparing the commits and pull request description. The implementation was reviewed by the submitter.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

This comment was marked as outdated.

@gziolo gziolo self-assigned this Aug 19, 2026
@gziolo
gziolo marked this pull request as ready for review August 19, 2026 07:43
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props gziolo.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

This comment was marked as outdated.

This comment was marked as outdated.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants