Build/Test Tools: Remove npx commands in 7.1 - #13108
Conversation
npx commands.When a binary is missing locally, `npx` installs the package and its dependencies, running every install script. This replaces each `npx` call with `npm exec --no`, which runs an installed binary and fails when the package is missing. Backport of r63309 to the 7.1 branch.
ba0d3d6 to
acea7c8
Compare
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Backport of r63309, already in trunk via #13021, to the
7.1branch. It replaces everynpxcall withnpm exec --no, which runs an installed binary and fails when the package is missing, and declaresupdate-browserslist-dbas a directdevDependency. That dependency is pinned to1.2.3, the version this branch already resolves, rather than trunk's1.3.1, so nothing is upgraded.Trac ticket: https://core.trac.wordpress.org/ticket/65864
Testing instructions
npm ci.npm exec --no -- playwright --version. It prints the installed version and downloads nothing.npm exec --no -- update-browserslist-db --version. It printsbrowserslist-lint 1.2.3.node_modules/update-browserslist-db, then runnpm exec --no -- update-browserslist-db. It fails withnpx canceled due to missing packages and no YES optioninstead of fetching the package. Restore the tree withnpm ci.CI=1 npm run grunt qunit. The QUnit tests pass.CI=1selects the system Chrome, as the workflow does. Without it, Playwright looks for a downloaded browser, so runnpm exec --no -- playwright installfirst.grep -rn npx Gruntfile.js tests/qunit/ .github/ package.json. It returns nothing.Use of AI Tools
AI assistance: Yes — Claude Code (Claude Opus 5) applied r63309 to the
7.1branch and verified the changeset.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.