Skip to content

Build/Test Tools: Remove npx commands in 7.1 - #13108

Open
adimoldovan wants to merge 1 commit into
WordPress:7.1from
adimoldovan:65864-remove-npx-7.1
Open

Build/Test Tools: Remove npx commands in 7.1#13108
adimoldovan wants to merge 1 commit into
WordPress:7.1from
adimoldovan:65864-remove-npx-7.1

Conversation

@adimoldovan

@adimoldovan adimoldovan commented Aug 17, 2026

Copy link
Copy Markdown

Backport of r63309, already in trunk via #13021, to the 7.1 branch. It replaces every npx call with npm exec --no, which runs an installed binary and fails when the package is missing, and declares update-browserslist-db as a direct devDependency. That dependency is pinned to 1.2.3, the version this branch already resolves, rather than trunk's 1.3.1, so nothing is upgraded.

Trac ticket: https://core.trac.wordpress.org/ticket/65864

Testing instructions

  1. Run npm ci.
  2. Run npm exec --no -- playwright --version. It prints the installed version and downloads nothing.
  3. Run npm exec --no -- update-browserslist-db --version. It prints browserslist-lint 1.2.3.
  4. Delete node_modules/update-browserslist-db, then run npm exec --no -- update-browserslist-db. It fails with npx canceled due to missing packages and no YES option instead of fetching the package. Restore the tree with npm ci.
  5. Run CI=1 npm run grunt qunit. The QUnit tests pass. CI=1 selects the system Chrome, as the workflow does. Without it, Playwright looks for a downloaded browser, so run npm exec --no -- playwright install first.
  6. Run grep -rn npx Gruntfile.js tests/qunit/ .github/ package.json. It returns nothing.

Use of AI Tools

AI assistance: Yes — Claude Code (Claude Opus 5) applied r63309 to the 7.1 branch and verified the changeset.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@desrosj desrosj moved this from Backlog to In progress in WordPress Project Build Tooling Aug 17, 2026
@adimoldovan adimoldovan changed the title Build/Test Tools: Remove all npx commands. Build/Test Tools: Remove npx commands in 7.1 Aug 18, 2026
When a binary is missing locally, `npx` installs the package and its
dependencies, running every install script. This replaces each `npx` call with
`npm exec --no`, which runs an installed binary and fails when the package is
missing.

Backport of r63309 to the 7.1 branch.
@adimoldovan
adimoldovan force-pushed the 65864-remove-npx-7.1 branch from ba0d3d6 to acea7c8 Compare August 18, 2026 08:44
@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@adimoldovan
adimoldovan marked this pull request as ready for review August 18, 2026 08:56
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props adrianmoldovanwp.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

2 participants