fix: ignore accidental short hold recordings - #56
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8005b49545
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "Accidental hold press ignored: %.3fs < %.3fs", | ||
| held_seconds, MIN_HOLD_PRESS_SECONDS, | ||
| ) | ||
| self.recording_discard.emit() |
There was a problem hiding this comment.
When a press shorter than 150 ms is discarded, last_trigger[workflow] still contains the key-down timestamp, so an immediate corrective press within DEBOUNCE_SECONDS (600 ms) is silently rejected by the debounce check and never starts recording. Clear that workflow's debounce entry when emitting recording_discard, or otherwise exempt the next key-down after a discard.
Useful? React with 👍 / 👎.
1 participant
Zusammenfassung
Verifikation
531 passed, 2 skippedgit diff --checksauber