Allow students to view the preview projects - #974
Open
DNR500 wants to merge 2 commits into
Open
Conversation
Test coverage93.34% line coverage reported by SimpleCov. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CanCanCan authorization in the Rails monolith to allow school students to access the unowned Experience CS preview starter project (and related data) so the editor-standalone classroom preview route can load the project successfully.
Changes:
- Adds a student-specific
:showpermission for unownedProjects of typeProject::Types::CODE_EDITOR_SCRATCH. - Adds a corresponding student-specific
:showpermission forComponents belonging to those unowned scratch projects.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+26
to
+30
| if user&.student? | ||
| # Allow students to view the Experience CS preview starter template. | ||
| can :show, Project, user_id: nil, school_id: nil, project_type: Project::Types::CODE_EDITOR_SCRATCH | ||
| can :show, Component, project: { user_id: nil, school_id: nil, project_type: Project::Types::CODE_EDITOR_SCRATCH } | ||
| return |
DNR500
marked this pull request as ready for review
August 19, 2026 16:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs to allow student view checks on issue: 1659
Comes out of this work on editor-standalone - https://github.com/RaspberryPiFoundation/editor-standalone/pull/1064
Summary
Updated
editor-apiCanCan permissions so that school students can:showthe Experience CS preview starter project used by the classroom preview route.With this changes students are now allowed to view unowned (
user_id: nil,school_id: nil) Scratch template projects.This prevents the preview route in editor-standalone from failing project loading (which previously triggered a redirect to
/${locale}/error).