core/validatorapi: adopt payload attestation interfaces

[KaloyanTanev]

Bump go-eth2-client to v0.29.0-obol.2-gloas (obol stack rebased onto upstream gloas with the merged ePBS transport and PTC endpoints from attestantio/go-eth2-client#310 and #311). Replace the temporary plain Handler methods with the upstream eth2client.PayloadAttestationDataProvider and eth2client.PayloadAttestationMessagesSubmitter interfaces, adapting the component and router to the versioned opts/response types. The VC-facing wire format is unchanged; the validated Eth-Consensus-Version header now selects the message version passed to the submitter.

category: refactor
ticket: #4324

[Copilot]

Pull request overview

Refactors the validator API’s payload attestation endpoints to use the upstream go-eth2-client payload attestation provider/submitter interfaces after bumping Charon’s forked go-eth2-client dependency for Gloas support, while keeping the VC-facing JSON wire format unchanged.

Changes:

• Bumps the attestantio/go-eth2-client replacement to github.com/ObolNetwork/go-eth2-client v0.29.0-obol.2-gloas.
• Updates core/validatorapi component methods to implement eth2client.PayloadAttestationDataProvider and eth2client.PayloadAttestationMessagesSubmitter using versioned opts/response/message types.
• Adapts router/tests/mocks to the new interfaces and propagates the validated Eth-Consensus-Version into submitted message versions.

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
go.sum	Updates module checksums for the bumped forked go-eth2-client version.
go.mod	Updates the replace directive to the new go-eth2-client fork version.
core/validatorapi/validatorapi.go	Implements upstream payload attestation provider/submitter interfaces and wraps data/messages in versioned containers.
core/validatorapi/validatorapi_test.go	Updates component tests to use opts structs and assert versioned response/message behavior.
core/validatorapi/router.go	Switches payload attestation routes to call the new interfaces and build versioned submit opts.
core/validatorapi/router_internal_test.go	Updates router tests for the new handler signatures and versioned message passing.
core/validatorapi/mocks/handler.go	Regenerates/updates mocks for the new payload attestation method signatures and types.

Files not reviewed (1)

• core/validatorapi/mocks/handler.go: Generated file

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[codecov]

Codecov Report

❌ Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (gloas@88c519c). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
core/validatorapi/validatorapi.go	71.42%	2 Missing and 2 partials ⚠️
core/validatorapi/router.go	88.23%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             gloas    #4658   +/-   ##
========================================
  Coverage         ?   58.84%           
========================================
  Files            ?      245           
  Lines            ?    34316           
  Branches         ?        0           
========================================
  Hits             ?    20193           
  Misses           ?    11617           
  Partials         ?     2506           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull request overview

Copilot reviewed 5 out of 7 changed files in this pull request and generated no new comments.

Files not reviewed (1)

• core/validatorapi/mocks/handler.go: Generated file

Suppressed comments (1)

core/validatorapi/router.go:1621

• payloadAttestationData dereferences eth2Resp.Data and then reads data.Version without guarding against a nil response or nil Data. If the provider ever returns (nil, nil) or a response with Data == nil, this handler will panic instead of returning an HTTP error.

		data := eth2Resp.Data
		if data.Version != eth2spec.DataVersionGloas || data.Gloas == nil {
			return nil, nil, errors.New("unsupported payload attestation data version")
		}