Bump flash attention 2 - #3403
Open
francesco-bertolotti wants to merge 1 commit into
Open
Conversation
Contributor
Greptile SummaryThe PR expands Transformer Engine’s accepted FlashAttention 2 range through version 2.8.4.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "bump FA" | Re-trigger Greptile |
francesco-bertolotti
force-pushed
the
f14-fa284
branch
from
August 19, 2026 15:10
92c9cdb to
07be442
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump the maximum supported FlashAttention version from v8.2.3 to v8.2.4.
Currently, Transformer Engine (TE) caps FlashAttention at v8.2.3. However, newer commits on the FlashAttention main branch include changes that would be useful to TE users, such as those introduced in Dao-AILab/flash-attention#2260.
Allowing FlashAttention v8.2.4 enables users to use TE with newer FlashAttention releases. I ran the test suite with the updated version, and the results were largely successful. The few failures appear to be related to my specific environment rather than the version bump itself.
Was there a specific reason for guarding against newer FlashAttention releases, or was it mainly intended to guard against potential API changes?
Changes