Skip to content

fix(docker): preserve provisioning failure status - #2830

Open
elezar wants to merge 1 commit into
mainfrom
codex/fix-docker-cdi-preflight
Open

fix(docker): preserve provisioning failure status#2830
elezar wants to merge 1 commit into
mainfrom
codex/fix-docker-cdi-preflight

Conversation

@elezar

@elezar elezar commented Aug 20, 2026

Copy link
Copy Markdown
Member

Summary

Preserve the explicit Docker provisioning failure while a transient container state is observed during cleanup, so invalid CDI requests report Docker's CDI error deterministically.

Related Issue

No issue required: localized CI-discovered lifecycle status race with focused regression coverage.

Changes

  • Keep explicit pending provisioning failures authoritative over transient Docker container snapshots.
  • Retain normal container state precedence while provisioning is still in progress.
  • Cover failure and non-failure reconciliation paths.

Testing

  • Failing CI reproduction: gpu-e2e / E2E Docker GPU (wsl-amd64), job 95793176038
  • git diff --check passes
  • mise run pre-commit (unavailable: mise is not installed in this workspace)
  • Unit tests (Rust tooling is unavailable in this workspace)
  • E2E tests (not run; covered by CI)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

@elezar
elezar requested review from a team, derekwaynecarr, mrunalp and sjenning as code owners August 20, 2026 09:46
@github-actions

Copy link
Copy Markdown

@elezar
elezar force-pushed the codex/fix-docker-cdi-preflight branch from b00a675 to 9554793 Compare August 20, 2026 10:29
@elezar elezar changed the title fix(docker): validate explicit CDI device inventory fix(docker): preserve provisioning failure status Aug 20, 2026
Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar
elezar force-pushed the codex/fix-docker-cdi-preflight branch from 9554793 to 80100c0 Compare August 20, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant