fix(cli): fail closed when OIDC refresh fails - #2817
Open
jhjaggars wants to merge 1 commit into
Open
Conversation
Signed-off-by: Jesse Jaggars <jjaggars@redhat.com>
jhjaggars
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
August 19, 2026 21:44
Member
|
/ok-to-test f57c5f6 |
|
Label |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop protected CLI commands before they send RPCs when automatic OIDC token refresh fails. This prevents
sandbox createfrom allocating a persistent sandbox with a stale token and then failing during a later protected RPC.Related Issue
No issue required: this is an obvious localized authentication bug fix with a focused regression test. Related context: #2675 documents how failed provisioning can leave a same-name sandbox that blocks retry.
Changes
openshell statusbehavior so it can report gateway reachability and authentication independentlyopenshell gateway login <name>guidance in the errorCreateSandboxfrom reaching the gatewayTesting
mise run pre-commitpassescargo test -p openshell-cliChecklist