feat(podman): export driver traces over OTLP - #2782
Open
krishicks wants to merge 1 commit into
Open
Conversation
krishicks
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
August 17, 2026 19:40
pimlock
reviewed
Aug 18, 2026
pimlock
left a comment
pimlock
left a comment
Collaborator
There was a problem hiding this comment.
Few comments after exploring this with an agent.
Comment on lines
-709
to
-712
| // 1a. Pull the supervisor image if needed. The supervisor binary | ||
| // is shipped in a standalone OCI image and mounted into sandbox | ||
| // containers via Podman's type=image mount. Refresh mutable tags | ||
| // like latest/dev, but avoid registry checks for pinned images. |
Collaborator
There was a problem hiding this comment.
nit: the different phases of creating a sandbox have numbered comments, but now the 1 is missing
Collaborator
There was a problem hiding this comment.
@krishicks the section with number 1. is still missing in the latest version, so the numbering starts at 2., which is confusing. Can we mark the first stage with 1.?
Mirror the VM driver tracing setup for Podman. Export standalone driver spans through OTLP/gRPC as the distinct openshell-driver-podman service, propagate W3C context across ComputeDriver RPCs, record bounded RPC names and failures, and flush buffered spans during graceful shutdown. Podman still runs in-process when selected as a built-in gateway driver. Add a temporary tracing shim that partitions gateway and Podman spans by target into separate tracer providers while preserving their shared trace and parentage. The shim also emits the same ComputeDriver server boundary that the tonic layer emits out of process, keeping the observable trace shape stable when Podman is eventually extracted. Trace container create preparation, image and storage setup, lifecycle operations, and cleanup. Document the service boundary and cover it with isolated and repeated tracing tests. Signed-off-by: Kris Hicks <khicks@nvidia.com>
krishicks
force-pushed
the
hicks/push-tvvqnrvruvko
branch
from
August 19, 2026 19:50
d621663 to
6be6a87
Compare
krishicks
enabled auto-merge
August 19, 2026 21:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirror the VM driver tracing setup for Podman. Export standalone driver spans through OTLP/gRPC as the distinct openshell-driver-podman service, propagate W3C context across ComputeDriver RPCs, record bounded RPC names and failures, and flush buffered spans during graceful shutdown.
Podman still runs in-process when selected as a built-in gateway driver. Add a temporary tracing shim that partitions gateway and Podman spans by target into separate tracer providers while preserving their shared trace and parentage. The shim also emits the same ComputeDriver server boundary that the tonic layer emits out of process, keeping the observable trace shape stable when Podman is eventually extracted.
Trace container create preparation, image and storage setup, lifecycle operations, and cleanup. Document the service boundary and cover it with isolated and repeated tracing tests.
Related Issue
#1055
#2507
Changes
Testing
mise run pre-commitpassesChecklist