Skip to content

fix: support stdin-backed file options on Windows - #208

Merged
NianJiuZst merged 1 commit into
MiniMax-AI:mainfrom
shaoohh:fix/cross-platform-stdin-input
Aug 21, 2026
Merged

fix: support stdin-backed file options on Windows#208
NianJiuZst merged 1 commit into
MiniMax-AI:mainfrom
shaoohh:fix/cross-platform-stdin-input

Conversation

@shaoohh

@shaoohh shaoohh commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix cross-platform support for documented - stdin inputs:

  • replace the POSIX-only /dev/stdin path with file descriptor 0
  • route mmx text chat --messages-file - through the shared helper
  • keep --text-file - and --lyrics-file - working through the same helper on Windows, macOS, and Linux

Root cause

The shared reader and text-chat command hard-coded /dev/stdin, which does not exist on Windows.

Tests

  • Adds regression coverage that the stdin marker resolves to file descriptor 0.
  • Isolated TypeScript check passes.

View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.

@NianJiuZst NianJiuZst left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking findings on the current head. Replacing the POSIX-only /dev/stdin path with file descriptor 0 preserves the documented --*-file - interface and makes it work on Windows, so I recommend merging it.

Verified against current main: focused test, a real piped text chat --messages-file - --dry-run probe, typecheck, and lint (one pre-existing warning). #208 and #229 also pass the combined full suite (402/402).

@NianJiuZst
NianJiuZst merged commit 73c2ef8 into MiniMax-AI:main Aug 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants