Skip to content

Hand SlimeLauncher the extracted metadata zip, cache extraction - #1084

Open
PaintNinja wants to merge 3 commits into
MinecraftForge:FG_7.0from
PaintNinja:7.0-provide-extracted-slimelauncher-metadata
Open

Hand SlimeLauncher the extracted metadata zip, cache extraction#1084
PaintNinja wants to merge 3 commits into
MinecraftForge:FG_7.0from
PaintNinja:7.0-provide-extracted-slimelauncher-metadata

Conversation

@PaintNinja

@PaintNinja PaintNinja commented Aug 18, 2026

Copy link
Copy Markdown
Contributor
  • Avoids needing to re-extract it every launch from SlimeLauncher's end
  • Zip extraction is now cached by Gradle's build cache feature across builds with the same metadata zip

I think this is the only task runs after configuration time that could be cached - if so, this PR also implements #993 as FG7 core now intentionally supports Gradle's Build Cache for this task.

- Avoids needing to re-extract it every launch from SlimeLauncher's end
- Zip extraction is now cached by Gradle's build cache feature across builds with the same metadata zip

@LexManos LexManos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would also need the ForgeDevPlugin side of things.

Comment thread src/main/java/net/minecraftforge/gradle/internal/SlimeLauncherMetadata.java Outdated
@PaintNinja
PaintNinja requested a review from LexManos August 19, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhances an existing feature in the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants