Skip to content

refactor!: drop profile-sync-controller dependency - #9918

Merged
mikesposito merged 4 commits into
mainfrom
me/refactor/drop-config-registry-controller-deps
Aug 20, 2026
Merged

refactor!: drop profile-sync-controller dependency#9918
mikesposito merged 4 commits into
mainfrom
me/refactor/drop-config-registry-controller-deps

Conversation

@mikesposito

@mikesposito mikesposito commented Aug 20, 2026

Copy link
Copy Markdown
Member

Explanation

The @metamask/config-registry-controller dependency over @metamask/profile-sync-controller is being dropped, by adding a new ConfigRegistryApiEnv enum to config-registry-controller package.

The new enum can be used to select the API environment the service should use.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Cursor Bugbot is generating a summary for commit bd18275. Configure here.

@mikesposito
mikesposito requested review from a team as code owners August 20, 2026 11:13
@mikesposito
mikesposito deployed to default-branch August 20, 2026 11:13 — with GitHub Actions Active
@mikesposito
mikesposito enabled auto-merge August 20, 2026 11:13
Comment thread packages/config-registry-controller/src/index.ts Outdated
Comment thread packages/config-registry-controller/CHANGELOG.md Outdated
Comment thread packages/config-registry-controller/CHANGELOG.md Outdated
Co-authored-by: Michele Esposito <34438276+mikesposito@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b402180. Configure here.

DEV = 'dev',
UAT = 'uat',
PRD = 'prod',
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRD env value mismatches predecessor

Medium Severity

ConfigRegistryApiEnv.PRD is 'prod', but the SDK.Env.PRD value it replaces is 'prd'. getConfigRegistryUrl treats anything other than 'prod' as a hostname prefix, so passing the previous production value builds client-config.prd-api... instead of the production host. Dev and UAT still match, so this only breaks production.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit b402180. Configure here.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't matter, since getConfigRegistryUrl matches the value against ConfigRegistryApiEnv.PRD, and in that case the env prefix will be simply omitted:

function getConfigRegistryUrl(env: ConfigRegistryApiEnv): string {
  const envPrefix = env === ConfigRegistryApiEnv.PRD ? '' : `${env}-`;
  return `https://client-config.${envPrefix}api.cx.metamask.io/v1${ENDPOINT_PATH}`;
}

@ulissesferreira ulissesferreira left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikesposito
mikesposito added this pull request to the merge queue Aug 20, 2026
Merged via the queue into main with commit 9a6bf41 Aug 20, 2026
74 checks passed
@mikesposito
mikesposito deleted the me/refactor/drop-config-registry-controller-deps branch August 20, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants