feat(assets-controller): add RPC vs Accounts API balance reconciliation - #9910
Open
salimtb wants to merge 2 commits into
Open
feat(assets-controller): add RPC vs Accounts API balance reconciliation#9910salimtb wants to merge 2 commits into
salimtb wants to merge 2 commits into
Conversation
Add refreshAccountChainBalancesFromRpc to compare a fresh Accounts API snapshot and on-chain RPC balance, report mismatches to Sentry, and merge RPC into state. Includes unit tests and changelog entry. Co-authored-by: Cursor <cursoragent@cursor.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 286bd3d. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refreshAccountChainBalancesFromRpc(accountId, assetId)to fetch a single asset balance via Accounts API (forceUpdate) and RPC, compare the two sources against each other and against current state, and report Sentry issues when Accounts API ≠ RPC or state ≠ Accounts API.Test plan
yarn workspace @metamask/assets-controller run jest --no-coverage src/AssetsController.test.ts -t "refreshAccountChainBalancesFromRpc"(15 tests)yarn workspace @metamask/assets-controller run buildMade with Cursor