Draft
Refactor serializer tests to shared base with DOM-specific subclasses#276
Conversation
…classes Co-authored-by: goetas <776743+goetas@users.noreply.github.com>
Co-authored-by: goetas <776743+goetas@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
goetas
August 18, 2026 05:57
View session
goetas
marked this pull request as ready for review
August 18, 2026 05:57
goetas
marked this pull request as draft
August 18, 2026 05:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #257’s serializer coverage for PHP 8.4
Dom\HTMLDocumentduplicated nearly the entire legacyOutputRulesTestsuite. This refactor keeps equivalent coverage while centralizing shared assertions and isolating only runtime-specific behavior.Shared test consolidation
AbstractOutputRulesTestwith commonOutputRulesserializer assertions.DOM-specific specialization
OutputRulesTestnow acts as the legacyDOMDocumentsubclass.OutputRulesNewDomTestnow acts as the PHP 8.4Dom\HTMLDocumentsubclass.Compatibility helpers
createCommentNode,createTextNode,createElementWithText) so each DOM implementation can construct nodes safely without duplicating full test methods.