Add adoptions #1018
There are no files selected for viewing
|
Collaborator
There was a problem hiding this comment. Risk here: "@mui/x-data-grid": "^8.28.6", Apparently this only supports @mui/material 5, 6, or 7 but this project pins @ 9. Fine to leave this, just know this is unsupported and we'll have to keep an eye on this to verify it doesn't break on any future updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| /* | ||
| * | ||
| * * Copyright (c) 2026 Board of Regents of the University of Wisconsin System | ||
| * * | ||
| * * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * * you may not use this file except in compliance with the License. | ||
| * * You may obtain a copy of the License at | ||
| * * | ||
| * * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * * | ||
| * * Unless required by applicable law or agreed to in writing, software | ||
| * * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * * See the License for the specific language governing permissions and | ||
| * * limitations under the License. | ||
| * | ||
| */ | ||
| import * as React from 'react'; | ||
| import { useState } from 'react'; | ||
| import { GridRenderEditCellParams, useGridApiContext } from '@mui/x-data-grid'; | ||
| import { Autocomplete, TextField } from '@mui/material'; | ||
|
|
||
| interface AutoCompleteEditCellParams { | ||
| options: any[] | ||
| required: boolean; | ||
| multiple?: boolean; | ||
| disableClearable?: boolean; | ||
| returnValueOnly?: boolean; | ||
| } | ||
|
|
||
| export const AutoCompleteEditCell = (props: GridRenderEditCellParams & AutoCompleteEditCellParams) => { | ||
| const { id, field, value, options, required, multiple, disableClearable, returnValueOnly } = props; | ||
| const apiRef = useGridApiContext(); | ||
| const [open, setOpen] = useState(true); | ||
|
|
||
| const handleChange = (event: any, newValue: any) => { | ||
| const val = returnValueOnly && newValue ? newValue.value : newValue; | ||
| apiRef.current.setEditCellValue({ id, field, value: val }); | ||
| if (!multiple && (newValue || newValue === null)) { | ||
| apiRef.current.stopCellEditMode({ id, field }); | ||
| } | ||
| }; | ||
|
|
||
| const handleKeyDown = (event: React.KeyboardEvent) => { | ||
| if (event.key === 'Tab') { | ||
| apiRef.current.stopCellEditMode({ id, field }); | ||
| } | ||
| }; | ||
|
|
||
| const isError = required && (value === null || value === undefined || (Array.isArray(value) && value.length === 0) || value === ''); | ||
| const selectedOption = multiple ? (value || []) : (options.find(opt => opt.value === value || opt === value || (typeof value === 'object' && value !== null && opt.value === value.value)) || null); | ||
|
|
||
| return ( | ||
| <Autocomplete | ||
| options={options} | ||
| getOptionLabel={(option) => option.label || ''} | ||
| value={selectedOption} | ||
| onChange={handleChange} | ||
| open={open} | ||
| onOpen={() => setOpen(true)} | ||
| onClose={(event, reason) => { | ||
| if (reason === 'selectOption' || reason === 'blur' || reason === 'escape') { | ||
| setOpen(false); | ||
| } | ||
| }} | ||
| fullWidth | ||
| multiple={multiple} | ||
| disableClearable={disableClearable} | ||
| isOptionEqualToValue={(option, value) => { | ||
| const val = (value && typeof value === 'object' && 'value' in value) ? value.value : value; | ||
| return option.value === val; | ||
| }} | ||
| renderInput={(params) => ( | ||
| <TextField | ||
| {...params} | ||
| autoFocus | ||
| variant="standard" | ||
| onKeyDown={handleKeyDown} | ||
| required={required} | ||
| error={isError} | ||
| /> | ||
| )} | ||
| /> | ||
| ); | ||
| }; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming this file works correctly as i'm not able to test all these nodes.
Ran it through Claude just to double check and the only catch is that it looks like this also deals with the @mui/material issue i mentioned in another comment. This file shows @mui/material resolved to 9.3.1 while @mui/x-data-grid resolved to 8.29.2. x-data-grid's peerDependencies only allow @mui/material 5, 6, and 7. Same as the other comment, feel free to leave this but just keep an eye on any future breakage due to this package combo being unsupported.