GitHub Issue #1434 Add visual padding to automatically generated X and Y axis ranges in charts - #3166
Open
cnathe wants to merge 3 commits into
Open
GitHub Issue #1434 Add visual padding to automatically generated X and Y axis ranges in charts#3166cnathe wants to merge 3 commits into
cnathe wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
https://github.com/LabKey/internal-issues/issues/1434
The charting code gets the min and max axis range values based on the data points when the scale is set to automatic. This means that the data points run right up to the edges of the chart. This PR updates that to add a bit of padding around the chart (i.e. to push out the min/max by 5%).
Related Pull Requests
Changes