Skip to content

Fix for SMEditableGridTest.testDragFillReadOnlyColumn #3160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DariaBod wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Fix for SMEditableGridTest.testDragFillReadOnlyColumn #3160

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5a3f8b4
fix drag fill test
DariaBod Jul 6, 2026
3e33740
fix comment
DariaBod Jul 6, 2026
03704a1
Merge branch 'develop' into fb_fixDragFillTest
DariaBod Aug 17, 2026
ca06ed3
add retry
DariaBod Aug 17, 2026
16cd427
add retry
DariaBod Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions src/org/labkey/test/components/ui/grids/EditableGrid.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1049,17 +1049,33 @@ public void dragFill(WebElement startCell, WebElement endCell)

/**
* Select {@code selectStart} through {@code dragEnd} and fill down from {@code selectEnd}'s row using Ctrl/Cmd+D.
* The drag that establishes the selection is occasionally treated as a click, leaving the key combination
* nothing to fill, so the whole sequence is retried once.
* @param selectStart top-left cell of the range to select
* @param selectEnd cell whose value will be filled down (must be in {@code selectStart}'s row)
* @param dragEnd bottom-right cell of the range to select and fill down to
*/
public void fillDown(WebElement selectStart, WebElement selectEnd, WebElement dragEnd)
{
selectCellRange(selectStart, dragEnd);
String fillValue = getCellValue(selectEnd);

selectAndFillDown(selectStart, dragEnd);
if (!WebDriverWrapper.waitFor(() -> fillValue.equals(getCellValue(dragEnd)), 3_000))
{
selectAndFillDown(selectStart, dragEnd);
WebDriverWrapper.waitFor(() -> fillValue.equals(getCellValue(dragEnd)),
"Fill-down did not populate end cell with value: " + fillValue, 5_000);
}
}

/**
* Drag-select {@code selectStart} through {@code dragEnd} and send the fill-down key combination.
*/
private void selectAndFillDown(WebElement selectStart, WebElement dragEnd)
{
dragToCell(selectStart, dragEnd);
WebDriverWrapper.waitFor(() -> isInSelection(selectStart) && isInSelection(dragEnd), 2_000);
new Actions(getDriver()).keyDown(MODIFIER_KEY).sendKeys("d").keyUp(MODIFIER_KEY).build().perform();
WebDriverWrapper.waitFor(() -> fillValue.equals(getCellValue(dragEnd)),
"Fill-down did not populate end cell with value: " + fillValue, 3_000);
}

public void selectCellRange(WebElement startCell, WebElement endCell)
Expand Down