Add audit log for successful LK version changes - #3159
Merged
Conversation
| @EarliestVersion(FIRST_AUDITED_VERSION) | ||
| public void testVersionChangeRecorded() throws Exception | ||
| { | ||
| Assume.assumeFalse("A version change is only visible after the upgrade", isUpgradeSetupPhase); |
Member
There was a problem hiding this comment.
This actually needs to check whether the setup happened on a different version. We have a sort of failsafe/sanity check for the upgrade pipeline that stays on the same version ("Upgrade validation" with no version).
Suggested change
| Assume.assumeFalse("A version change is only visible after the upgrade", isUpgradeSetupPhase); | |
| Assume.assumeFalse("A version change is only visible after the upgrade", setupVersion.equals(TestProperties.getProductVersion())); |
Contributor
Author
There was a problem hiding this comment.
@labkey-tchad I made a bigger change. The most recent run passed but my followup commit should fix it. This is ready for you to take another look at your convenience.
Contributor
Author
|
@labkey-tchad The latest run is now passing on the upgrade tests. |
labkey-tchad
approved these changes
Aug 21, 2026
Comment on lines
+207
to
+210
| finally | ||
| { | ||
| permissionsHelper.removeUserRoleAssignment(projectAdmin.getEmail(), PermissionsHelper.SEE_AUDIT_LOG_SITE_ROLE, "/"); | ||
| } |
Member
There was a problem hiding this comment.
This isn't really necessary since we delete the user immediately after this.
Contributor
Author
There was a problem hiding this comment.
True. Simplified.
cnathe
added a commit
to LabKey/platform
that referenced
this pull request
Aug 21, 2026
## Rationale In order to understand when their servers were upgraded, we want to expose a new audit table that tracks deployments/startups with new builds. #### Related Pull Requests - #7943 - LabKey/testAutomation#3159 - LabKey/labkey-ui-components#2063 - LabKey/limsModules#2418 ## Changes - New System Upgrade audit table - Populate table with a new row every startup that's using a different build - Variant of getAuditEvents() for setting maxRows --------- Co-authored-by: Susan Hert <susanh@labkey.com> Co-authored-by: cnathe <cnathe@labkey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
In order to understand when their servers were upgraded, we want to expose a new audit table that tracks deployments/startups with new builds.
Related Pull Requests
Changes