GitHub Issue #1037: Calculated columns on assays don't get round tripped through folder archive - #7959
Open
cnathe wants to merge 5 commits into
Open
GitHub Issue #1037: Calculated columns on assays don't get round tripped through folder archive#7959cnathe wants to merge 5 commits into
cnathe wants to merge 5 commits into
Conversation
…attempt to createQueryDef for them in postProcess
XingY
approved these changes
Aug 20, 2026
|
|
||
| for (Map.Entry<String, QueryDocument> entry : qic.deferredMetadataFiles.entrySet()) | ||
| { | ||
| String metaFileName = entry.getKey(); |
Contributor
There was a problem hiding this comment.
This seems mostly duplicate code inside process. Can those be refactored?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
https://github.com/LabKey/internal-issues/issues/1037
Assay calculated columns are exported as query metadata XML overrides against per-protocol schemas (
assay.General.<name>).QueryImporter.process()runs before the XAR importer creates the protocols, so the query xml files for these assay protocols get dropped with a warning. The fix stashes those files in a newdeferredMetadataFilesmap and replays them frompostProcess(), after every importer's process() has run.Related Pull Requests
Changes