Move ExecuteSqlCommand into the SelectRowsCommand inheritance hierarchy - #95
Merged
Conversation
labkey-adam
changed the title
labkey-adam
requested review from
labkey-jeckels,
labkey-susanh and
labkey-tchad
August 18, 2026 22:59
labkey-susanh
approved these changes
Aug 19, 2026
labkey-tchad
approved these changes
Aug 19, 2026
labkey-adam
added a commit
to LabKey/platform
that referenced
this pull request
Aug 20, 2026
## Rationale Form was conveying this flag, but action wasn't passing it along to `ApiQueryResponse`. LabKey/internal-issues#1414 ## Related Pull Requests - LabKey/labkey-api-java#95
labkey-adam
added a commit
to LabKey/server
that referenced
this pull request
Aug 20, 2026
## Rationale v8.0.0 was published ## Related Pull Requests - LabKey/labkey-api-java#95
labkey-adam
added a commit
to LabKey/testAutomation
that referenced
this pull request
Aug 20, 2026
## Rationale `RequestType` generic type parameter on `Command` is no longer supported ## Related Pull Requests - LabKey/labkey-api-java#95
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Client requested that we add missing support for the
includeMetadataoption onExecuteSqlCommand. https://github.com/LabKey/internal-issues/issues/1414Related Pull Requests
Changes
BaseQueryCommand, addBaseSelectRowsCommand, and fold ExecuteSqlCommand into that hierarchy, so it can share the large number of common properties and handling withSelectRowCommand. This addsincludeMetadatasupport "for free", eliminates a large amount of redundant code, and ensures future properties can be implemented in both easily.RequestTypegeneric type parameter onCommand. This was added recently (by me) but it adds little value and makes it more difficult to implement inheritance hierarchies where parents and children might need different HTTP methods.GetCommand,PostCommand, and subclass methods can continue to returnHttpGetorHttpPostif they wish, so this has very little impact.BaseSelectinterface. This early attempt at keeping ExecuteSqlCommand and SelectRowsCommand in sync is no longer needed since they now share a common base class that implements all shared property handling.StopImpersonatingCommandto usestopImpersonatingApi. This means that, on success, the command now returns a success status code instead of a redirect.GetContainersResponseandGetUsersCommand