Add use case for (un)assigning roles on datasets and collections - #416
Open
vera wants to merge 9 commits into
Open
Add use case for (un)assigning roles on datasets and collections#416vera wants to merge 9 commits into
vera wants to merge 9 commits into
Conversation
scolapasta
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
# Conflicts: # docs/useCases.md # src/collections/index.ts # src/datasets/domain/repositories/IDatasetsRepository.ts # src/datasets/index.ts # src/datasets/infra/repositories/DatasetsRepository.ts
…tasets and collections
ekraffmiller
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS Dataverse Project
ekraffmiller
left a comment
ekraffmiller
left a comment
Contributor
There was a problem hiding this comment.
Hi @vera , this looks good, the only thing I noticed is that the APIs for assigning a role return the roleAssignmentId, but the use case returns void. Can you update the assignRole use cases to return the newly created roleAssignmentId?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds code for
Which issue(s) this PR closes:
/
Related Dataverse PRs:
/
Special notes for your reviewer:
/
Suggestions on how to test this:
I've added tests and docs on how to use.
Is there a release notes or changelog update needed for this change?:
Yes
Additional documentation:
/