feat(lsp): transient-open lifecycle, workspace queue, and env scrubbing (DSH 2.12) - #217
Merged
Patel230 merged 1 commit intoAug 20, 2026
Conversation
…ng (DSH 2.12) Port of DSH lsp/lsp-stdio operational semantics into Hawk. - lsp: Implemented ExecuteTransient managing per-file transient didOpen (version 1, full text) -> query -> didClose defer lifecycle with 10 MiB ReadBoundedSource cap. - lsp: Implemented WorkspaceQueue providing per-workspace FIFO execution queue with context-abortable locking. - lsp: Implemented ScrubEnvironment removing ambient sensitive environment variables (KEY, PASSWORD, SECRET, TOKEN, etc.) with tok.SecretDetector value scanning and explicit config merging. - lsp: Implemented KillProcessTree and WaitForProcessQuiescence across Unix (POSIX process groups) and Windows (taskkill /T /F). - lsp: Updated initialize request with null processId per DSH specification. - tools: Updated all file-based LSP tools (diagnostics, goto_definition, find_references, symbols, prepare_rename, rename) to execute via ExecuteTransient. - tests: Added test suites for environment scrubbing, process tree disposal, workspace FIFO ordering, parallel workspace execution, source bounding, and transient lifecycle.
Patel230
deleted the
feat/dsh-harness-rfc-2.12-lsp-transient-open-env-scrubbing
branch
August 20, 2026 14:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port of DSH
lsp/lsp-stdiooperational semantics into Hawk (Phase 2.12 of DSH RFC port plan).ExecuteTransientmanaging per-file transientdidOpen(version 1, full text) -> query ->didClose(defer) lifecycle with 10 MiBReadBoundedSourcecap.WorkspaceQueueproviding per-workspace FIFO execution queue with context-abortable locking. Distinct workspaces execute concurrently.ScrubEnvironmentstripping ambient sensitive environment variables (KEY,PASSWORD,SECRET,TOKEN,AUTH,CREDENTIAL,PRIVATE,BEARER,SIGNATURE,APIKEY) and detecting secret values viatok.DefaultSecretDetector(). Merges explicit configuration values after the scrub.KillProcessTreeacross POSIX process groups (Unix) andtaskkill /T /F(Windows), withWaitForProcessQuiescencepolling.processId: nullper DSH specification.lsp_diagnostics,lsp_goto_definition,lsp_find_references,lsp_symbols,lsp_prepare_rename,lsp_rename) to execute throughExecuteTransient.Verification
go test -race ./internal/lsp/... ./internal/tools/...-> PASS./scripts/check-internal-layer-imports.sh-> PASSmake lint-> 0 issueshawk verify-> verification passed