Skip to content

Fix the inverted condition for USE_LEGACY_ZOOM_FACTOR - #1075

Open
HEIHUAa wants to merge 1 commit into
CodenameCrew:mainfrom
HEIHUAa:fix-zoom
Open

Fix the inverted condition for USE_LEGACY_ZOOM_FACTOR#1075
HEIHUAa wants to merge 1 commit into
CodenameCrew:mainfrom
HEIHUAa:fix-zoom

Conversation

@HEIHUAa

@HEIHUAa HEIHUAa commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Fix the inverted condition for USE_LEGACY_ZOOM_FACTOR.
For nearly a year, the value set for USE_LEGACY_ZOOM_FACTOR has been correct, but the final code had the logic reversed. When USE_LEGACY_ZOOM_FACTOR was disabled, it actually used the 0.1.0 calculation method, while enabling it used the new one instead.

@HEIHUAa

HEIHUAa commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

Additionally, I would like to check whether DEFAULT_SOUND_TIME_SCALED_PITCH seems to be inverted as well. In version 1.0.1, it was enabled by default to follow the pitch, while in the new version it is disabled. If this is confirmed to be a mistake, it could be changed to: if (DEFAULT_SOUND_TIME_SCALED_PITCH == null) DEFAULT_SOUND_TIME_SCALED_PITCH = MOD_API_VERSION < 3;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant