Migrate to callback-based authentication for libssh 0.12 - #622
Merged
michalvasko merged 1 commit intoAug 20, 2026
Merged
Conversation
HanzlikPetr
force-pushed
the
pr_libssh_deprecated_functions
branch
from
August 10, 2026 11:40
c069926 to
4020c09
Compare
michalvasko
requested changes
Aug 10, 2026
HanzlikPetr
force-pushed
the
pr_libssh_deprecated_functions
branch
2 times, most recently
from
August 10, 2026 13:14
30a5925 to
a818cb1
Compare
Roytak
requested changes
Aug 14, 2026
Roytak
left a comment
Roytak
left a comment
Contributor
There was a problem hiding this comment.
Looks okay, most of the comments were small things. I also noticed there is now significant code duplication between the callback and message paths (e.g. shadow kbdint, pubkey comparison and such), these could probably be moved to session_server_ssh.c and shared between the two.
HanzlikPetr
force-pushed
the
pr_libssh_deprecated_functions
branch
2 times, most recently
from
August 18, 2026 15:17
8cd5fc1 to
ec1f8ed
Compare
Roytak
requested changes
Aug 19, 2026
Roytak
left a comment
Roytak
left a comment
Contributor
There was a problem hiding this comment.
Reviewed. We should also eventually add more tests for PAM, since only the 'happy' path is tested now, without any timeouts/cancels/more prompts. But not in this PR, just noting it down
HanzlikPetr
force-pushed
the
pr_libssh_deprecated_functions
branch
from
August 20, 2026 10:29
ec1f8ed to
b6722c2
Compare
Roytak
requested changes
Aug 20, 2026
HanzlikPetr
force-pushed
the
pr_libssh_deprecated_functions
branch
from
August 20, 2026 11:58
b6722c2 to
39f7447
Compare
Roytak
approved these changes
Aug 20, 2026
michalvasko
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.