Skip to content

[bugfix] Fix progress bar accuracy for VFR videos #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Breakthrough merged 3 commits into from
Aug 17, 2026
+8 −1
Merged

[bugfix] Fix progress bar accuracy for VFR videos #562

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc2d5de
fix: update progress bar accuracy for VFR
nathanmdan Aug 3, 2026
246ee7d
fix: update progress bar for frame skips
nathanmdan Aug 17, 2026
8a6029f
Update scenedetect/scene_manager.py
nathanmdan Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion scenedetect/scene_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,6 +571,7 @@ def detect_scenes(
)
decode_thread.start()
frame_im = None
prev_position = None

logger.info("Detecting scenes...")
try:
Expand All @@ -587,7 +588,13 @@ def detect_scenes(
progress_bar.set_description(
PROGRESS_BAR_DESCRIPTION % len(self._cutting_list), refresh=False
)
progress_bar.update(1 + frame_skip)
# Increment progress bar by delta of position.frame_num instead of 1
# to handle VFR video where frame count is an approximation.
delta = (
1 if prev_position is None else position.frame_num - prev_position.frame_num
)
progress_bar.update(delta)
prev_position = position
finally:
if progress_bar is not None:
progress_bar.set_description(
Expand Down
Loading