ci: run tests on PRs into feat/** branches, not just main - #38
Merged
Conversation
Stacked PRs got no CI. A chain like feat/a <- feat/b <- feat/c only ever triggered the workflow on the PR targeting main, so the branches carrying the most unreviewed change were the ones with no test, lint, or security run — each only got gated after its parent merged and it was retargeted. Found while landing the 10DLC stack: two PRs with ~8k lines between them were running Snyk only.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
joshraub-bw
approved these changes
Aug 20, 2026
achandras
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs currently get no CI.
ci.ymltriggers onpull_request: branches: [main], so in a chain likefeat/a <- feat/b <- feat/c, only the PR targetingmainruns the workflow. Every child PR shows Snyk checks and nothing else — no test matrix, no lint, no security job — until its parent merges and it gets retargeted.That inverts the intent: the branches accumulating the most unreviewed change are the ones with no gate.
Found while landing the 10DLC stack. #32 and #33 carry roughly 8k lines between them and have been running Snyk only. Both pass locally (33 packages,
vet/gofmt/golangci-lintclean), but "the author ran it locally" is not the assurance CI is there to provide.The change
Plus a comment explaining why, so it does not get simplified back later.
Cost
A few extra minutes of Actions time per push to a stacked PR. Scoped to
feat/**rather than**so ordinary topic branches are unaffected — they get their CI when they open againstmain, as today.