feat(tui): UX hardening for approvals, thinking, tool steps, and errors - #27
Merged
Conversation
Five improvements from a holistic UI/UX review: - Approval flow: replace bare-letter instant decisions with an arrow-select + Enter option list (typing mid-prompt can no longer fire a decision); tab expands the full untruncated command; esc is an explicit labelled deny; transcript scrolling works while pending. - Thinking: ^T posts a note and shows a persistent "✳ think" header badge; full reasoning is stored and ^E unfolds it on finalized turns; the collapsed excerpt shows the head of the thought. - Tool steps: expanded output preserves whitespace (diffs/code keep alignment); mouse toggling only fires on the step header row; ^E shows a persistent "▼ details" footer indicator; running steps get a chevron affordance. - Feedback: send failures finalize the turn with an inline error; disconnect mid-turn finalizes with an "interrupted" marker (idempotent, resume-safe); /cancel reports idle/success/queue outcomes; the "r retry" hint only shows when it works; the disconnected-submit warning is sticky with correct advice. - Narrow terminals: banner falls back to a one-line wordmark below the art width; model name truncates and the header is clamped to its 2-row budget; step-arg truncation floors lowered for tiny widths. Regression tests for every fix; coverage stays at 98.9%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the top 5 findings from a holistic UI/UX review of the TUI. One cohesive commit; every change has regression tests.
↑↓-select +⏎-confirm option list, so typing mid-prompt can't fire a decision.tabexpands the full untruncated command (previously ellipsized to one line),escis an explicit labelled deny, and transcript scrolling works while the panel is open.^Tposts a note and shows a persistent✳ thinkheader badge; full reasoning is stored and^Eunfolds it on finalized turns (was permanently capped at 240 runes); the collapsed excerpt shows the head of the thought instead of the tail.^Eshows a persistent▼ detailsindicator; running steps get a chevron affordance.**Error:**(no more phantom empty turns); disconnect mid-turn finalizes with an**Interrupted:**marker (idempotent, resume-safe);/cancelreports idle/success/queue outcomes; ther retryhint only renders when it actually works; the disconnected-submit warning is sticky with correct advice.⬡ bodekwordmark below the art width; model name truncates with ellipsis and the header is hard-clamped to its 2-row budget (viewport/mouse math can't drift); step-arg truncation floors lowered for tiny widths.Test plan
make fmt/make vetcleanmake lint— 0 issuesmake test— full-racesuite green, all packagesmake cover— 98.9% internal coverage; all functions touched here at 100%