Antalya 26:6 Multiple fixes for Iceberg operations by subkanthi · Pull Request #2157 · Altinity/ClickHouse

subkanthi · 2026-08-04T01:00:24Z

continuation of work from #1841

Changelog category (leave one):

Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixes ALTER TABLE ... ADD COLUMN, DROP COLUMN, RENAME COLUMN and MODIFY COLUMN on Iceberg tables, which could fail against a REST catalog -- DROP COLUMN of the most recently added column was rejected with Invalid last column ID, and an ALTER that the catalog had in fact applied could come back as Column already exists on retry. Bool and Decimal(P, S) columns can now be used in CREATE TABLE and ALTER TABLE ... ADD COLUMN, and a Decimal precision above the Iceberg limit of 38 is now refused up front. Dropping a column that the table's sort order or partition spec still references is now rejected, as the Iceberg specification requires.

CI/CD Options

Exclude tests:

Regression jobs to run:

github-actions · 2026-08-04T01:01:58Z

Workflow [PR], commit [7e09133]

subkanthi · 2026-08-06T21:11:05Z

ADD COLUMN

Ubuntu-2404-noble-amd64-base :) ALTER table ice.`default.dest5` add column new_column Nullable(UInt64);

ALTER TABLE ice.`default.dest5`
    (ADD COLUMN `new_column` Nullable(UInt64))

Query id: 825e8155-ec00-45f0-a54e-63291f46ef10

Ok.

0 rows in set. Elapsed: 0.314 sec. 

Ubuntu-2404-noble-amd64-base :) show create table ice.`default.dest5`;

SHOW CREATE TABLE ice.`default.dest5`

Query id: 0c79176a-55dd-4aa4-a4c4-2125f5cde5fe

   ┌─statement────────────────────────────────────────────────┐
1. │ CREATE TABLE ice.`default.dest5`                        ↴│
   │↳(                                                       ↴│
   │↳    `event_month` Int32,                                ↴│
   │↳    `id` Int64,                                         ↴│
   │↳    `event_time` DateTime64(6),                         ↴│
   │↳    `user_id` Int32,                                    ↴│
   │↳    `category_name` String,                             ↴│
   │↳    `value` Float64,                                    ↴│
   │↳    `payload` String,                                   ↴│
   │↳    `col2` Nullable(Int64),                             ↴│
   │↳    `new_column` Nullable(Int64)                        ↴│
   │↳)                                                       ↴│
   │↳ENGINE = Iceberg('http://localhost:9000/bucket1/dest6/') │
   └──────────────────────────────────────────────────────────┘

DROP COLUMN

 alter table ice.`default.dest5` drop column col2;

ALTER TABLE ice.`default.dest5`
    (DROP COLUMN col2)

Query id: a7905249-670b-4ac2-a626-f95535c02730

Connecting to database ice at localhost:9007 as user default.
Connected to ClickHouse server version 26.6.2.

Ok.

0 rows in set. Elapsed: 0.122 sec. 

Ubuntu-2404-noble-amd64-base :) show create table ice.`default.dest5`;

SHOW CREATE TABLE ice.`default.dest5`

Query id: 9d3b156a-ca6d-4997-917a-8bf36d4d7058

   ┌─statement────────────────────────────────────────────────┐
1. │ CREATE TABLE ice.`default.dest5`                        ↴│
   │↳(                                                       ↴│
   │↳    `event_month` Int32,                                ↴│
   │↳    `id` Int64,                                         ↴│
   │↳    `event_time` DateTime64(6),                         ↴│
   │↳    `user_id` Int32,                                    ↴│
   │↳    `category_name` String,                             ↴│
   │↳    `value` Float64,                                    ↴│
   │↳    `payload` String,                                   ↴│
   │↳    `new_column` Nullable(Int64)                        ↴│
   │↳)                                                       ↴│
   │↳ENGINE = Iceberg('http://localhost:9000/bucket1/dest6/') │
   └──────────────────────────────────────────────────────────┘

1 row in set. Elapsed: 0.016 sec.

RENAME COLUMN

 alter table ice.`default.dest5` rename column new_column to new_column_2;

ALTER TABLE ice.`default.dest5`
    (RENAME COLUMN new_column TO new_column_2)

Query id: e464f77e-0e3d-4ffc-883e-70db1260327f

Ok.

0 rows in set. Elapsed: 0.169 sec. 

Ubuntu-2404-noble-amd64-base :) show create table ice.`default.dest5`;

SHOW CREATE TABLE ice.`default.dest5`

Query id: 0b4b4e06-7d58-4583-821a-95e27f856ba9

   ┌─statement────────────────────────────────────────────────┐
1. │ CREATE TABLE ice.`default.dest5`                        ↴│
   │↳(                                                       ↴│
   │↳    `event_month` Int32,                                ↴│
   │↳    `id` Int64,                                         ↴│
   │↳    `event_time` DateTime64(6),                         ↴│
   │↳    `user_id` Int32,                                    ↴│
   │↳    `category_name` String,                             ↴│
   │↳    `value` Float64,                                    ↴│
   │↳    `payload` String,                                   ↴│
   │↳    `new_column_2` Nullable(Int64)                      ↴│
   │↳)                                                       ↴│
   │↳ENGINE = Iceberg('http://localhost:9000/bucket1/dest6/') │
   └──────────────────────────────────────────────────────────┘

1 row in set. Elapsed: 0.017 sec.

subkanthi · 2026-08-06T23:41:17Z

 {
    switch (type->getTypeId())
    {
+        case TypeIndex::UInt8:


Added support for bool

subkanthi · 2026-08-06T23:41:31Z

            return {"string", true};
        case TypeIndex::UUID:
            return {"uuid", true};
+        case TypeIndex::Decimal32:


Added support for iceberg decimal types.

….com/Altinity/ClickHouse into antalya_26_6_fix_alter_table_iceberg

subkanthi · 2026-08-07T20:19:46Z

Decimal support


ALTER TABLE ice.`flowers.sample`
ADD COLUMN dec_col Nullable(Decimal(10,2));

ALTER TABLE ice.`flowers.sample`
    (ADD COLUMN `dec_col` Nullable(Decimal(10, 2)))

Query id: 83a0ae12-2b00-40de-85ba-654daa0d7dc0

Ok.

0 rows in set. Elapsed: 0.203 sec. 

Ubuntu-2404-noble-amd64-base :) show create table ice.`flowers.sample`;

SHOW CREATE TABLE ice.`flowers.sample`

Query id: bb3b8676-9b7e-4000-9b08-2fcb30b65079

   ┌─statement─────────────────────────────────────────────────────────┐
1. │ CREATE TABLE ice.`flowers.sample`                                ↴│
   │↳(                                                                ↴│
   │↳    `value` Nullable(Int64),                                     ↴│
   │↳    `boolean_col` Nullable(Bool),                                ↴│
   │↳    `dec_col` Nullable(Decimal(10, 2))                           ↴│
   │↳)                                                                ↴│
   │↳ENGINE = Iceberg('http://localhost:9000/bucket1/flowers/sample/') │
   └───────────────────────────────────────────────────────────────────┘

1 row in set. Elapsed: 0.009 sec.

mkmkme · 2026-08-14T10:41:44Z

Could you fix the conflicts please?

DimensionWieldr · 2026-08-14T13:33:30Z

Agent found a potential issue:

Nested ADD COLUMN + commit-unknown recovery

iceberg_alter_catalog_commit_reported_as_failed makes RestCatalog::updateSchema apply the catalog commit and then return false. The ALTER retry path is supposed to notice the column is already there via MetadataGenerator::isAddColumnApplied and treat the op as succeeded.

That works for a primitive ADD COLUMN z Nullable(String) (test_writes_alter_when_commit_is_reported_as_failed). It does not work for nested types.

SET allow_insert_into_iceberg = 1, enable_nullable_tuple_type = 1;
ALTER TABLE … ADD COLUMN tuple_col Nullable(Tuple(Int32, String));

Code: 36. DB::Exception: Column tuple_col already exists. (BAD_ARGUMENTS)

The catalog already committed the column. Recovery missed it, so the retry called generateAddColumnMetadata again.

Cause

isAddColumnApplied (MetadataGenerator.cpp ~181–199) rebuilds the expected Iceberg type with getIcebergType(type, last_column_id) using the current last-column-id (already advanced by the successful commit).

For primitives that is a string ("string", "long", …) and the compare succeeds.

For Array / Map / Tuple, getIcebergType allocates new nested field ids from that high watermark. icebergTypesEqual stringifies the JSON, so element-id / key-id / value-id / struct field ids do not match the committed type → returns false → retry → Column already exists.

….com/Altinity/ClickHouse into antalya_26_6_fix_alter_table_iceberg

DimensionWieldr · 2026-08-14T22:53:54Z

PR CI Triage Summary

Iceberg ALTER coverage passed (iceberg_1). None of these are caused by this PR. Same jobs are already red on MasterCI antalya-26.6
(https://github.com/Altinity/ClickHouse/actions/runs/31713806632).

iceberg_2 — EXPORT PARTITION tests against a 26.6 binary that does not have that feature. Unrelated to Iceberg ALTER.

s3_export_part — same export-feature mismatch, then cascade after the server died. Sanity cases passed.

settings — missing snapshots for new 26.6 settings. Already failing on MasterCI.

Stateless amd_debug + distributed plan + s3 — three 600s timeouts. Passed on the other stateless jobs in this run. Known flakes.

swarms — historically flaky node-restart test. Already failing on MasterCI.

tiered_storage_minio — disk-name flake. Passed on the other tiered-storage jobs in this run and on MasterCI.

…data, reject decimal with precision > 38, fix modify column

mkmkme · 2026-08-18T11:26:38Z

@blau-ai

blau-ai · 2026-08-18T11:35:23Z

CI triage for #2157 (`ed3480d`)

Verdict: 9 red checks → 1 PR-caused (must fix), 5 pre-existing, 3 flaky/infra.

Baseline for comparison: the latest antalya-26.6 MasterCI run (d42f80a, run 32099065740). Every regression suite below ran the identical scope on that base run, so "green on base / red here" is a real signal.

Check	Class	Cause
Regression release iceberg_2	🔴 PR-caused	Whole `export partition` feature broken
Regression release settings	🟡 pre-existing	Fails on base too; unrelated settings
Regression release s3_export_part	🟡 pre-existing	Fails on base too
SQLLogic test	🟡 pre-existing/infra	Fails on base too; run under-executed
Regression release s3_aws_s3_2	⚪ flaky/infra	Single retry-level error, unrelated code
Regression release tiered_storage_minio	⚪ flaky	Single scenario, non-Iceberg code
Stateless (amd_debug, parallel)	⚪ flaky	Passed on rerun; non-blocking
Stateless (amd_debug, distributed plan, s3 storage)	⚪ flaky	Unrelated test; non-blocking
PR (aggregate)	—	Gate reflecting the above

🔴 PR-caused — must fix before merge

Regression release iceberg_2 — job

This PR: 207 features (79 ok, 97 failed, 31 skipped), 258 scenarios failed.
Base antalya-26.6 (same --only ".../export partition/*" scope): 188 features (112 ok, 76 skipped), 1892 scenarios (1851 ok, 0 failed) → green.

100% of the failures are under /iceberg/export partition/…, and they fail across every catalog backend — no catalog, ice catalog, and glue catalog:

✘ /iceberg/export partition/ice catalog/plain merge tree/manifest integrity/each export advances the snapshot list by one
✘ /iceberg/export partition/glue catalog/plain merge tree/transactions/sequential exports append one append-snapshot each
✘ /iceberg/export partition/no catalog/plain merge tree/transactions/…
✘ …/manifest integrity/snapshot summary total-records matches exported row count

The scenarios fail fast (≈0.5–1.7 s) on snapshot/metadata assertions (append-snapshot count, snapshot-list length, snapshot-summary total-records). That pattern — every export scenario tripping early on the snapshot the export produces, regardless of catalog — points at the Iceberg metadata/snapshot generation path, which this PR rewrites substantially:
- src/Storages/ObjectStorage/DataLakes/Iceberg/MetadataGenerator.cpp (rewritten several times across the 19 commits — 143-, 120-, 63-line hunks)
- src/Storages/ObjectStorage/DataLakes/Iceberg/Mutations.cpp
- src/Storages/ObjectStorage/DataLakes/Iceberg/Utils.cpp, Compaction.cpp

Suggested next steps (I can't pin the exact line from CI alone — see caveat below):

Pull the per-scenario diff (expected vs actual snapshot/metadata) from the report — it isn't in the GHA log, only in the artifact:
iceberg2 report ·
fails.log.txt ·
nice-new-fails.log.txt
Because export-partition is broken uniformly (not just the alter/catalog cases this PR targets), the regression was almost certainly introduced by one of the later MetadataGenerator/Mutations refactor commits rather than the alter feature itself. Reproduce locally with just:
--only "/iceberg/export partition/no catalog/plain merge tree/transactions/*" and bisect those commits.
Confirm the emitted metadata.json still writes a correct snapshots list / snapshot-log / summary total-records after the refactor — that's what the failing assertions check.

🟡 Pre-existing (red on `antalya-26.6` as well — not this PR)

Regression release settings — 6 default values mismatches, none of them settings this PR touches:
ai_function_embedding_default_credentials, ai_function_text_default_credentials, analyzer_compatibility_apply_final_to_all_joined_tables, export_merge_tree_partition_retry_initial_backoff_seconds, export_merge_tree_partition_retry_max_backoff_seconds, object_storage_propagate_credentials_to_other_storages. Classic testflows default-value reference drift. Base settings job = failure.
Regression release s3_export_part — S3Export (part) also = failure on the base run. Pre-existing.
SQLLogic test — failure reason is total tests 4,951,919 < minimum 5,939,581: the run executed too few tests (timeout/under-run), not a content failure. Base SQLLogic test = failure too. Infra/pre-existing — safe to re-run.

⚪ Flaky / infra (green on base, single scenario, outside this PR's code)

Regression release s3_aws_s3_2 — one [ Error ] in /s3/aws s3/part 2/orphans/full replication/detach and drop/run #3 (a retry, replication-cleanup timeout). Unrelated to Iceberg. Re-run.
Regression release tiered_storage_minio — one [ Fail ] in /tiered storage/with minio/alter table policy (8 s). That's MergeTree storage-policy ALTER, a different code path from this PR's Iceberg ALTER. Unrelated; re-run.
Stateless (amd_debug, parallel) — 00060_move_to_prewhere_and_sets failed once (308 s) then: "All reruns passed. The failure is not reproducible (likely a transient issue)". Job exited 0 (non-blocking).
Stateless (amd_debug, distributed plan, s3 storage, parallel) — 03519_storage_url (URL table function; nothing to do with Iceberg). Job exited 0 (non-blocking).

Caveat: I triage from CI evidence only — I can't build ClickHouse or run the suites in this environment, and I can't fetch the S3 artifact bodies, so I can't quote the exact expected/actual snapshot diff or name the precise broken line. The classification above is grounded in the base-vs-PR job comparison and the failing-scenario names; the exact fix should be confirmed against the fails.log.txt / report linked above. Happy to draft the fix as a separate blau/* PR (or, if you want it committed straight onto antalya_26_6_fix_alter_table_iceberg, say so) once the root-cause line is identified.

_{🤖 automated CI triage by @blau-ai}

DimensionWieldr · 2026-08-18T13:38:24Z

Hmm, that CI Triage is a bit inaccurate. All plain merge tree fails in the export partition suite are expected. The other failures on replicated merge tree are worth looking at though. (I will take a close look later today.)

I also just updated the regression tests release branch to hold the fixes to a lot of failing tests. The next CI run should be less red.

UPDATE

After close inspection:

/iceberg/export partition/no catalog/replicated merge tree/datatypes/ is the one failure of interest I discovered. New datatypes mappings to iceberg such as CH UInt8 -> Iceberg Int are new to 26.6. Tests have been updated to reflect this.

Other replicated merge tree fails are due to outdated tests or old issues whose tests should've been skipped on this build.

…placed throw with log message when table-uuid is missing

…d and replaced throw with log message when table-uuid is missing" This reverts commit 71faeb8.

`OPTIMIZE TABLE` on an Iceberg table started failing when any file in the table's `metadata/` directory lacked `table-uuid`: Code: 36. DB::Exception: Table UUID is not specified in some metadata files for table by path .../metadata/1-0000...-0000.metadata.json. (BAD_ARGUMENTS) `table-uuid` is optional at `format-version` 1, so a leftover v1 metadata file - from before the table was upgraded, or from an external engine that omits the optional field - was enough to break compaction on an otherwise healthy table. `SELECT`, `INSERT` and `ALTER TABLE ... ADD COLUMN` on the same table were unaffected. The cause was `getPlan` opting into table-UUID-based metadata file selection, which parses every metadata file in the directory and requires the field on each one. It was the only call site of `getLatestOrExplicitMetadataFileAndVersion` that did so; all 15 others use the lenient default. Besides the hard failure it also turned metadata selection from a filename-only comparison into O(N) object storage reads per `OPTIMIZE`. Restore the previous behaviour at that call site and drop the `select_by_table_uuid` parameter, which now has no callers. Metadata selection in `getLatestMetadataFileAndVersion` is unchanged, so the pre-existing strict path used by the `iceberg_metadata_table_uuid` setting keeps working exactly as before. This reverts the metadata selection part of the change; the preceding commit reverted the follow-up that had turned the resulting exception into a debug message. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

…s branch The test issues `OPTIMIZE TABLE ... MANIFEST` with `iceberg_manifest_min_count_to_compact`, and neither exists here: OPTIMIZE TABLE t MANIFEST -> Code: 62. Syntax error: failed at position 32 (MANIFEST). Expected one of: ... PARTITION, DRY RUN, FINAL, FORCE, DEDUPLICATE, CLEANUP ... (SYNTAX_ERROR) SELECT 1 SETTINGS iceberg_manifest_min_count_to_compact = 2 -> Code: 115. Unknown setting 'iceberg_manifest_min_count_to_compact'. (UNKNOWN_SETTING) Manifest-only compaction is not part of `antalya-26.6`. `tests/integration/test_storage_iceberg_multistorage/test.py` already records this with an explicit `pytest.mark.skip` on `test_optimize_manifest_with_external_manifest_list` for the same reason, so the test would have failed on its first statement had the integration suite run. It was added to cover the table-UUID-based metadata file selection in `getPlan`, which the previous two commits reverted, so there is nothing left for it to exercise. Drop it rather than skip it; it can come back with the feature it tests. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

`snapshots`, `metadata-log` and `snapshot-log` are optional in the Iceberg spec, so table metadata written by another engine may omit any of them - typically for a table that has never been written to. `INSERT` into such a table leaked a raw Poco exception as `Code: 1000 (POCO_EXCEPTION)`: Exception: Can not extract empty value (`snapshots` absent) Poco::NullPointerException (`metadata-log` absent) Poco::NullPointerException (`snapshot-log` absent) Five accesses assumed the fields are present: * `getMaxSequenceNumber` and `getParentSnapshot` extracted `snapshots` from an empty `Poco::Dynamic::Var`, which throws instead of yielding a null array. Both now treat an absent array as "no snapshot history": sequence number 0 and no parent snapshot. `getParentSnapshot` already returns `nullptr` when no snapshot matches, and every caller guards on that, so no new null path is introduced. * The `snapshots`, `metadata-log` and `snapshot-log` appends in `generateNextMetadata` dereferenced the null array returned by `Poco::JSON::Object::getArray` for a missing key. They now go through `getOrCreateArray`, which creates an empty array first - the same approach already used for `refs` and `properties` a few lines below. `getMaxSequenceNumber` returns early on `last-sequence-number`, which is required at format-version 2, so only a spec-violating table reaches its `snapshots` read; it is guarded for consistency rather than for a reachable failure. This makes `test_insert_into_table_without_optional_metadata_arrays` pass. That test was added by c72983e together with the `sort-orders` and `partition-specs` guards for `DROP COLUMN`, as part of one sweep over absent optional metadata fields - but the write-path half of the sweep was never implemented, so the test has been asserting behaviour that did not exist. It also needed `io` and `get_file_contents` imported, which are added here. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

…UMN contracts Three behaviours introduced by this pull request had no unit coverage. `decimal` precision. The Iceberg spec caps `decimal(P, S)` at precision 38 while ClickHouse `Decimal256` reaches 76, so wider precisions have to be refused rather than written into metadata other engines would reject. The tests sweep every precision from 1 to 38 and assert the resulting `decimal(P, S)` string, then assert rejection for 39, 50 and 76. Both sides of the boundary come from a named constant carrying the spec limit, so moving the check in `getIcebergType` fails the tests in both directions. `isModifyColumnApplied`. Five cases covering what the predicate is for: a type already in the schema, a type not yet there, the `required` versus nullable distinction, a column absent from the schema, and the case the predicate exists for - a catalog that applied `Int32` -> `UInt64` and reported the commit as failed, where Iceberg records both as `long` and a retry has to recognise the change as already present. `MODIFY COLUMN` rejection. A change Iceberg cannot record must be rejected *and* leave the metadata untouched, because the original defect was a silent no-op that let the caller persist a ClickHouse schema the Iceberg metadata did not reflect. `expectModifyRejected` asserts the error code and that `current-schema-id` and the `schemas` array are unchanged, for an indistinguishable primitive (`Int32` -> `UInt32`) and an indistinguishable nested type (`Tuple(a Int32)` -> `Tuple(a UInt32)`). Two positive controls keep the suite honest: a no-op MODIFY adds no schema, and a widening `Int32` -> `Int64` adds one schema, moves `current-schema-id`, and records `long` for the field in the schema that id points at. The stored schemas are described directly with a `makeMetadataWithField` helper rather than produced by calling the generator, so the tests check what the Iceberg metadata says instead of whether two functions in this class agree with each other. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

`DropColumnRejectsIfInSortOrder` and `DropColumnRejectsIfInPartitionSpec` asserted only `EXPECT_THROW(..., DB::Exception)`, which passes for any exception raised anywhere in the call - a `getValue` failure on malformed fixture data, or a `LOGICAL_ERROR` from an unrelated code path, would both have satisfied it. They also said nothing about whether a half-applied schema was left behind, which is the reason rejecting matters: the caller must not go on to persist a ClickHouse schema that the Iceberg metadata does not reflect. Both now go through `expectDropRejected`, which asserts that the call throws, that the code is `BAD_ARGUMENTS`, and that `current-schema-id` and the `schemas` array are unchanged afterwards - the same contract `expectModifyRejected` already checks for `MODIFY COLUMN`. `ModifyColumnRejectsIndistinguishableType` is removed: it covers the same scenario as `ModifyColumnRejectsIndistinguishablePrimitiveType` (`int` stored, `UInt32` requested) while asserting strictly less. `SchemaState`, `readSchemaState` and `expectSchemaUnchanged` move to the first anonymous namespace so the earlier tests can use them, instead of duplicating the comparison. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

mkmkme · 2026-08-19T11:32:38Z

Fixed the issues raised during the code review phase. Also changed the title and the changelog entry since those no longer described what the PR does exactly.

I also unchecked sanitizers tests so those are not skipped anymore. Let's see how the CI goes

mkmkme · 2026-08-19T11:40:53Z

One of Claude's notes:

Follow-ups, deliberately out of scope. Iceberg's S ≤ P rule is unchecked in getIcebergType; identical complex MODIFY now throws where the primitive path no-ops; no retry backoff on 100 attempts; allowPrimitiveTypeConversion/parseDecimal duplicated between
SchemaProcessor.cpp and MetadataGenerator.cpp; createEmptyMetadataFile understates last-column-id for nested types; Glue/non-transactional orphan metadata cleanup.

Fix alter operations for iceberg

e93ce1c

subkanthi added 2 commits August 4, 2026 10:18

Merge branch 'antalya-26.6' into antalya_26_6_fix_alter_table_iceberg

fa311a9

Merge branch 'antalya-26.6' into antalya_26_6_fix_alter_table_iceberg

818f446

subkanthi changed the title ~~Fix alter operations for iceberg~~ Antalya 26:6 Fix alter operations for iceberg Aug 6, 2026

subkanthi added 3 commits August 5, 2026 22:16

Merge branch 'antalya-26.6' into antalya_26_6_fix_alter_table_iceberg

d62b9ac

fix medium defects with retries

0eb31fc

Added support for boolean and decimal

f76fd1d

subkanthi marked this pull request as ready for review August 6, 2026 04:26

subkanthi added 2 commits August 6, 2026 16:46

Add missing include to gtest_iceberg_type_mapping

bdb0d15

Merge branch 'antalya-26.6' into antalya_26_6_fix_alter_table_iceberg

d3b65e3

subkanthi closed this Aug 6, 2026

subkanthi reopened this Aug 6, 2026

subkanthi added the antalya-26.6 label Aug 6, 2026

subkanthi closed this Aug 6, 2026

subkanthi reopened this Aug 6, 2026

subkanthi closed this Aug 6, 2026

subkanthi reopened this Aug 6, 2026

subkanthi closed this Aug 6, 2026

subkanthi reopened this Aug 6, 2026

subkanthi commented Aug 6, 2026

View reviewed changes

subkanthi added 2 commits August 7, 2026 03:13

Restored removed tests

04c009e

Merge branch 'antalya_26_6_fix_alter_table_iceberg' of https://github…

a4e6f39

….com/Altinity/ClickHouse into antalya_26_6_fix_alter_table_iceberg

This was referenced Aug 7, 2026

Iceberg DataLakeCatalog: ALTER DELETE fails with Metadata is not initialized (LOGICAL_ERROR) #2136

Open

Iceberg ALTER ADD COLUMN does not support Bool/Decimal #2089

Open

subkanthi added 2 commits August 7, 2026 22:34

Fix to support decimal datatypes in iceberg

6e6f1f7

Merge branch 'antalya-26.6' into antalya_26_6_fix_alter_table_iceberg

ad9e5c7

subkanthi requested a review from DimensionWieldr August 13, 2026 20:15

subkanthi added 2 commits August 14, 2026 09:15

Merge branch 'antalya-26.6' into antalya_26_6_fix_alter_table_iceberg

a983d97

Merge branch 'antalya_26_6_fix_alter_table_iceberg' of https://github…

3a09c32

….com/Altinity/ClickHouse into antalya_26_6_fix_alter_table_iceberg

DimensionWieldr mentioned this pull request Aug 14, 2026

Iceberg ADD COLUMN of nested types fails commit-unknown recovery with Column already exists #2215

Open

Replace AssertInitialized with AssertInitializedDL

62ba6a0

subkanthi and others added 4 commits August 15, 2026 16:58

Merge branch 'antalya-26.6' into antalya_26_6_fix_alter_table_iceberg

166a872

Merge branch 'antalya-26.6' into antalya_26_6_fix_alter_table_iceberg

1f995d3

Added 408 to retry code , reject expire snapshots before writing meta…

998bb35

…data, reject decimal with precision > 38, fix modify column

Merge branch 'antalya-26.6' into antalya_26_6_fix_alter_table_iceberg

ed3480d

subkanthi added 2 commits August 18, 2026 18:24

Added tests to validate compaction when there is no table-uuid and re…

71faeb8

…placed throw with log message when table-uuid is missing

Merge branch 'antalya-26.6' into antalya_26_6_fix_alter_table_iceberg

a5309fa

svb-alt added antalya antalya-26.6.2.20001 labels Aug 19, 2026

mkmkme and others added 7 commits August 19, 2026 11:31

Merge branch 'antalya-26.6' into antalya_26_6_fix_alter_table_iceberg

38c9787

Revert "Added tests to validate compaction when there is no table-uui…

9a638ab

…d and replaced throw with log message when table-uuid is missing" This reverts commit 71faeb8.

mkmkme changed the title ~~Antalya 26:6 Fix alter operations for iceberg~~ Antalya 26:6 Multiple fixes for Iceberg operations Aug 19, 2026

mkmkme approved these changes Aug 19, 2026

View reviewed changes

Navigation Menu

Uh oh!

Antalya 26:6 Multiple fixes for Iceberg operations - #2157

Antalya 26:6 Multiple fixes for Iceberg operations#2157
subkanthi wants to merge 42 commits into
antalya-26.6from
antalya_26_6_fix_alter_table_iceberg

subkanthi commented Aug 4, 2026 •

edited by mkmkme

Loading

Uh oh!

github-actions Bot commented Aug 4, 2026 •

edited

Loading

Uh oh!

subkanthi commented Aug 6, 2026 •

edited

Loading

Uh oh!

subkanthi Aug 6, 2026

Uh oh!

subkanthi Aug 6, 2026

Uh oh!

subkanthi commented Aug 7, 2026 •

edited

Loading

Uh oh!

mkmkme commented Aug 14, 2026

Uh oh!

DimensionWieldr commented Aug 14, 2026

Uh oh!

DimensionWieldr commented Aug 14, 2026 •

edited

Loading

Uh oh!

mkmkme commented Aug 18, 2026

Uh oh!

blau-ai commented Aug 18, 2026

Uh oh!

DimensionWieldr commented Aug 18, 2026 •

edited

Loading

Uh oh!

mkmkme commented Aug 19, 2026

Uh oh!

mkmkme commented Aug 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

subkanthi commented Aug 4, 2026 • edited by mkmkme Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

CI/CD Options

Exclude tests:

Regression jobs to run:

Uh oh!

github-actions Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

subkanthi commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

subkanthi Aug 6, 2026

Choose a reason for hiding this comment

Uh oh!

subkanthi Aug 6, 2026

Choose a reason for hiding this comment

Uh oh!

subkanthi commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkmkme commented Aug 14, 2026

Uh oh!

DimensionWieldr commented Aug 14, 2026

Nested ADD COLUMN + commit-unknown recovery

Cause

Uh oh!

DimensionWieldr commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR CI Triage Summary

Uh oh!

mkmkme commented Aug 18, 2026

Uh oh!

blau-ai commented Aug 18, 2026

CI triage for #2157 (ed3480d)

🔴 PR-caused — must fix before merge

🟡 Pre-existing (red on antalya-26.6 as well — not this PR)

⚪ Flaky / infra (green on base, single scenario, outside this PR's code)

Uh oh!

DimensionWieldr commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkmkme commented Aug 19, 2026

Uh oh!

mkmkme commented Aug 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

subkanthi commented Aug 4, 2026 •

edited by mkmkme

Loading

github-actions Bot commented Aug 4, 2026 •

edited

Loading

subkanthi commented Aug 6, 2026 •

edited

Loading

subkanthi commented Aug 7, 2026 •

edited

Loading

DimensionWieldr commented Aug 14, 2026 •

edited

Loading

CI triage for #2157 (`ed3480d`)

🟡 Pre-existing (red on `antalya-26.6` as well — not this PR)

DimensionWieldr commented Aug 18, 2026 •

edited

Loading