Skip to content

[PWGCF] FU: adding colCheck (D0 MC process), mother PDG check (eff-base), fixing a bug in PurityQA process (D0 task) - #17493

Open
kgwizdzi wants to merge 3 commits into
AliceO2Group:masterfrom
kgwizdzi:femtoUni20260818
Open

[PWGCF] FU: adding colCheck (D0 MC process), mother PDG check (eff-base), fixing a bug in PurityQA process (D0 task)#17493
kgwizdzi wants to merge 3 commits into
AliceO2Group:masterfrom
kgwizdzi:femtoUni20260818

Conversation

@kgwizdzi

Copy link
Copy Markdown
Contributor

Changes in femtoUniverseProducerTask.cxx:

  • adding the possibility to reject the MC Truth collisions which are not reconstructed in processTrackD0MC

Changes in femtoUniverseEfficiencyBase.cxx:

  • adding the possibility to check the mother PDG at generated and reconstructed level, by setting confCheckMotherPDG to true, the PDG code of the mother is checked and the particle is rejected if its mother PDG is same as provided with the configurable confMotherPDGCode
  • fixing all code checker errors

Changes in femtoUniversePairTaskTrackD0.cxx:

  • fixing a bug in fillQA function called in processPurityQA

@github-actions github-actions Bot added the pwgcf label Aug 18, 2026
@github-actions github-actions Bot changed the title FU: adding colCheck (D0 MC process), mother PDG check (eff-base), fixing a bug in PurityQA process (D0 task) [PWGCF] FU: adding colCheck (D0 MC process), mother PDG check (eff-base), fixing a bug in PurityQA process (D0 task) Aug 18, 2026
@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 1be094f at 2026-08-18 11:44:

No log files found

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 7b830ac at 2026-08-18 12:37:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 2 errors and 0 warnings.'
Found 2 errors and 0 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/98d7a176268e30f58a96b2a7daeaf576a757a72a/O2Physics-code-check/errors.txt
PWGCF/FemtoUniverse/Tasks/femtoUniverseEfficiencyBase.cxx:334:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniverseEfficiencyBase.cxx:543:12: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants