Skip to content

[PWGLF] Refactor MC condition and histogram registration - #17490

Open
njacazio wants to merge 1 commit into
masterfrom
njacazio-patch-3
Open

[PWGLF] Refactor MC condition and histogram registration#17490
njacazio wants to merge 1 commit into
masterfrom
njacazio-patch-3

Conversation

@njacazio

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the pwglf label Aug 18, 2026
@github-actions github-actions Bot changed the title Refactor MC condition and histogram registration [PWGLF] Refactor MC condition and histogram registration Aug 18, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 1 errors, ⚠️ 30 warnings, 🔕 0 disabled

@njacazio
njacazio marked this pull request as ready for review August 18, 2026 08:05
@mpuccio
mpuccio enabled auto-merge (squash) August 18, 2026 08:15
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 073905f at 2026-08-18 10:35:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 12 errors and 201 warnings.'
Found 12 errors and 201 warnings.
++ [[ 12 -gt 0 ]]
++ cat /sw/BUILD/dba59d803f8bf3a0ce2c2cd9183f09428f0c49ec/O2Physics-code-check/errors.txt
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:79:8: error: constructor does not initialize these fields: nBinspT, hEffpTEta_proton, hEffpTEta_antiproton, hEffpTEta_deuteron, hEffpTEta_antideuteron, ccdb, pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:217:5: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:471:38: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:568:38: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:676:11: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:752:97: error: the parameter 'filepath' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:752:115: error: the parameter 'histname' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:754:5: error: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:759:24: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:764:28: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:769:26: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:774:30: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
++ [[ 201 -gt 0 ]]
++ cat /sw/BUILD/dba59d803f8bf3a0ce2c2cd9183f09428f0c49ec/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:641:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:644:77: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:817:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:819:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:822:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:824:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:826:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:828:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:831:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:894:60: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:896:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:898:60: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:900:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:903:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:905:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:909:87: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:911:87: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:916:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:918:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:923:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:925:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:936:60: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:938:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:940:60: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:942:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:945:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:947:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:951:87: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants