[PWGEM,Photon] Clean up code base - #17485
Merged
Merged
Conversation
- Move old unsused table producer tasks to `Legacy` folder to reduce compile time but keeping the code for completeness - Remove `#include <ASoA.h>` where ever possible to reduce compile time - Add CCDB Columns and SOA Timestamped tables for `o2::emcal::BadChannelMap` and `o2::parameters::GRPMagField`. This should help speed up CCDB access by putting the CCDB objects into shared memory. Especially useful for Dalitz + PCM skimmer and every task that runs with multiple sub-wagons. - Remove configurable that are no longer needed due to the above addition - Reduce `PresliceOptional` calls in Pi0EtaToGammaGamma to have the bare minimum argument. - Add Concepts where possible to improve compile time - Fix linter errors and warnings - Fix wrong position of header guard in `PWGEM/PhotonMeson/DataModel/EventTables.h` (was after all includes, is now before all includes) - Fix the partition used in the Pi0Flow task by using `INT16_MAX`, since there currently is a bug in arrow when using values above `INT16_MAX` when cutting on uint16_t values. Bugfix in arrow should come soon tho.
mhemmer-cern
requested review from
alibuild,
amaringarcia,
dsekihat,
hscheid,
jokonig and
reygers
as code owners
August 17, 2026 18:58
github-actions
Bot
added
pwgem
datamodel
photon
|
O2 linter results: ❌ 906 errors, |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
mhemmer-cern
marked this pull request as draft
August 18, 2026 05:52
- Add `#include ASoA.h` back whenever `.begin()` or `.end()` was used in the code. - Move more tasks to `Legacy` folder - Add CCDB column usage to more `emcalPhotonMcTask`
Collaborator
Author
|
code-check will fail due to some Legacy code, but I do not want to spend time fixing code that is specifically marked as old and unused. |
- Move `skimmerDalitzEE.cxx` to `Legacy`, `skimmerPrimaryElectronFromDalitzEE.cxx` should be used instead - Add `#include <Framework/ASoA.h>` everywhere with `globalIndex()` in use - Fix different linter warnings and errors and some of the touched files
mhemmer-cern
marked this pull request as ready for review
August 18, 2026 10:59
jokonig
approved these changes
Aug 18, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
|
Error while checking build/O2Physics/code-check for 91ea153 at 2026-08-18 19:09: Full log here. |
Collaborator
Author
|
I will merge this now and take care of these: In another PR later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacyfolder to reduce compile time but keeping the code for completeness.#include <Framework/ASoA.h>. If.begin(),.end()or.globalIndex()is used it should be included. If none of the functions coming from there are used it should be removed.o2::emcal::BadChannelMapando2::parameters::GRPMagField. This should help speed up CCDB access by putting the CCDB objects into shared memory. Especially useful for Dalitz + PCM skimmer and every task that runs with multiple sub-wagons.PresliceOptionalcalls inPi0EtaToGammaGammaheader files to have the bare minimum argument.Conceptswhere possible to improve compile time.MinMTracksandMinMSTrackstable.PWGEM/PhotonMeson/DataModel/EventTables.h(was after all includes, is now before all includes)INT16_MAX, since there currently is a bug in arrow when using values aboveINT16_MAXwhen cutting on uint16_t values. Bugfix in arrow should come soon tho, see alisw/arrow@0f5153d