[PWGCF] twoParticleCorrelationsMpi.cxx: add MC validation for templated event-by-event MPI proxy estimator by EmilGorm · Pull Request #17439 · AliceO2Group/O2Physics

EmilGorm · 2026-08-12T18:25:40Z

Added MC validation histograms to processMCSameDerived path
Added a new extension table to CorrelationsDerived.h: CFMCCollisionsExtra containing truth MPI information
Updated filterCorrelations to fill the truth MPI information into the new table

github-actions · 2026-08-12T18:25:59Z

O2 linter results: ❌ 36 errors, ⚠️ 4 warnings, 🔕 1 disabled

alibuild · 2026-08-12T21:35:07Z

Error while checking build/O2Physics/code-check for d8ce1c5 at 2026-08-12 23:35:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 25 errors and 23 warnings.'
Found 25 errors and 23 warnings.
++ [[ 25 -gt 0 ]]
++ cat /sw/BUILD/363e93b7f714a8185a2b6b57105bb46ad02e1da7/O2Physics-code-check/errors.txt
PWGCF/TableProducer/filterCorrelations.cxx:49:10: error: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:56:9: error: macro 'FLOAT_PRECISION' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:57:78: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:59:8: error: constructor does not initialize these fields: pdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:136:36: error: initializer for member 'multiplicities' is redundant [readability-redundant-member-init,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:167:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:181:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:236:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:240:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:435:54: error: narrowing conversion from 'double' to 'int8_t' (aka 'signed char') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:560:19: error: an assignment within an 'if' condition is bug-prone [bugprone-assignment-in-if-condition,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:560:21: error: narrowing conversion from 'Double_t' (aka 'double') to 'int8_t' (aka 'signed char') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:189:5: error: function 'isValid' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:190:5: error: function 'nearYield' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:191:5: error: function 'awayYield' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:192:5: error: function 'nuncSeeds' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:579:10: error: implicit conversion 'const TNamed *' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:583:10: error: implicit conversion 'const TNamed *' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:590:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:600:42: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:611:19: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:620:47: error: no header providing "std::size_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:654:5: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:655:48: error: no header providing "TObject" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:727:66: error: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer,-warnings-as-errors]
++ [[ 23 -gt 0 ]]
++ cat /sw/BUILD/363e93b7f714a8185a2b6b57105bb46ad02e1da7/O2Physics-code-check/warnings.txt
PWGCF/TableProducer/filterCorrelations.cxx:162:56: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:179:59: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:181:11: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:305:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:307:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:309:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:311:67: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:313:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:318:28: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:327:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:374:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:376:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:455:34: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:484:60: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:486:60: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

EmilGorm · 2026-08-12T22:16:50Z

The code check/linter fixes to the table producer are outside the scope of this PR.

alibuild · 2026-08-13T03:40:57Z

Error while checking build/O2Physics/code-check for 6298cf0 at 2026-08-13 05:40:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 12 errors and 23 warnings.'
Found 12 errors and 23 warnings.
++ [[ 12 -gt 0 ]]
++ cat /sw/BUILD/8be9d73ae81d7a3cbc2b7e9e85f53714de82b3d3/O2Physics-code-check/errors.txt
PWGCF/TableProducer/filterCorrelations.cxx:49:10: error: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:56:9: error: macro 'FLOAT_PRECISION' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:57:78: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:59:8: error: constructor does not initialize these fields: pdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:136:36: error: initializer for member 'multiplicities' is redundant [readability-redundant-member-init,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:167:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:181:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:236:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:240:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:435:54: error: narrowing conversion from 'double' to 'int8_t' (aka 'signed char') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:560:19: error: an assignment within an 'if' condition is bug-prone [bugprone-assignment-in-if-condition,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:560:21: error: narrowing conversion from 'Double_t' (aka 'double') to 'int8_t' (aka 'signed char') [bugprone-narrowing-conversions,-warnings-as-errors]
++ [[ 23 -gt 0 ]]
++ cat /sw/BUILD/8be9d73ae81d7a3cbc2b7e9e85f53714de82b3d3/O2Physics-code-check/warnings.txt
PWGCF/TableProducer/filterCorrelations.cxx:162:56: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:179:59: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:181:11: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:305:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:307:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:309:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:311:67: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:313:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:318:28: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:327:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:374:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:376:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:455:34: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:484:60: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:486:60: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:488:65: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:490:69: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:492:60: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:497:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:510:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:556:113: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:559:76: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:560:49: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 12 -gt 0 ]]
++ exit 1
--

Full log here.

alibuild · 2026-08-13T09:39:11Z

Error while checking build/O2Physics/o2 for 6298cf0 at 2026-08-13 11:39:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-08-14T02:08:27Z

Error while checking build/O2Physics/code-check for bc073ba at 2026-08-14 04:08:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 12 errors and 23 warnings.'
Found 12 errors and 23 warnings.
++ [[ 12 -gt 0 ]]
++ cat /sw/BUILD/a6ffc7c9fe4bc599cd341c758f2b69604706c7c2/O2Physics-code-check/errors.txt
PWGCF/TableProducer/filterCorrelations.cxx:49:10: error: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:56:9: error: macro 'FLOAT_PRECISION' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:57:78: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:59:8: error: constructor does not initialize these fields: pdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:136:36: error: initializer for member 'multiplicities' is redundant [readability-redundant-member-init,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:167:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:181:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:236:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:240:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:435:54: error: narrowing conversion from 'double' to 'int8_t' (aka 'signed char') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:560:19: error: an assignment within an 'if' condition is bug-prone [bugprone-assignment-in-if-condition,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:560:21: error: narrowing conversion from 'Double_t' (aka 'double') to 'int8_t' (aka 'signed char') [bugprone-narrowing-conversions,-warnings-as-errors]
++ [[ 23 -gt 0 ]]
++ cat /sw/BUILD/a6ffc7c9fe4bc599cd341c758f2b69604706c7c2/O2Physics-code-check/warnings.txt
PWGCF/TableProducer/filterCorrelations.cxx:162:56: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:179:59: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:181:11: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:305:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:307:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:309:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:311:67: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:313:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:318:28: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:327:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:374:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:376:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:455:34: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:484:60: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:486:60: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:488:65: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:490:69: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:492:60: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:497:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:510:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:556:113: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:559:76: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:560:49: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 12 -gt 0 ]]
++ exit 1
--

Full log here.

EmilGorm added 2 commits August 12, 2026 10:10

remove unused configurables

4f61a01

add MC validation of estimator with truth nMPI

41a08d2

github-actions Bot added pwgcf datamodel labels Aug 12, 2026

github-actions Bot changed the title ~~twoParticleCorrelationsMpi.cxx: add MC validation for templated event-by-event MPI proxy estimator~~ [PWGCF] twoParticleCorrelationsMpi.cxx: add MC validation for templated event-by-event MPI proxy estimator Aug 12, 2026

linter for twoParticleCorrelationsMpi.cxx

d8ce1c5

EmilGorm marked this pull request as ready for review August 12, 2026 19:02

EmilGorm requested review from alibuild, dsarkaralice, jaelpark, jgrosseo, lauraser, victor-gonzalez and wenyaCern as code owners August 12, 2026 19:02

wenyaCern previously approved these changes Aug 12, 2026

View reviewed changes

wenyaCern enabled auto-merge (squash) August 12, 2026 21:40

code check for twoParticleCorrelationsMpi.cxx

6298cf0

EmilGorm dismissed wenyaCern’s stale review via 6298cf0 August 12, 2026 22:15

wenyaCern previously approved these changes Aug 13, 2026

View reviewed changes

Merge branch 'master' into mpi-template-mc-validation

bc073ba

EmilGorm dismissed wenyaCern’s stale review via bc073ba August 13, 2026 16:17

jgrosseo approved these changes Aug 14, 2026

View reviewed changes

wenyaCern approved these changes Aug 14, 2026

View reviewed changes

wenyaCern merged commit 3988b3d into AliceO2Group:master Aug 15, 2026
13 of 15 checks passed

EmilGorm deleted the mpi-template-mc-validation branch August 20, 2026 12:26

Navigation Menu

Uh oh!

[PWGCF] twoParticleCorrelationsMpi.cxx: add MC validation for templated event-by-event MPI proxy estimator - #17439

[PWGCF] twoParticleCorrelationsMpi.cxx: add MC validation for templated event-by-event MPI proxy estimator#17439
wenyaCern merged 5 commits into
AliceO2Group:masterfrom
EmilGorm:mpi-template-mc-validation

EmilGorm commented Aug 12, 2026

Uh oh!

github-actions Bot commented Aug 12, 2026 •

edited

Loading

Uh oh!

alibuild commented Aug 12, 2026

Uh oh!

EmilGorm commented Aug 12, 2026 •

edited

Loading

Uh oh!

alibuild commented Aug 13, 2026

Uh oh!

alibuild commented Aug 13, 2026

Uh oh!

alibuild commented Aug 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

EmilGorm commented Aug 12, 2026

Uh oh!

github-actions Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Aug 12, 2026

Uh oh!

EmilGorm commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Aug 13, 2026

Uh oh!

alibuild commented Aug 13, 2026

Uh oh!

alibuild commented Aug 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Aug 12, 2026 •

edited

Loading

EmilGorm commented Aug 12, 2026 •

edited

Loading