From 68e57b10183d2bbad1daa95ae2f22cc90ed0587d Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 16 Aug 2026 13:07:03 +0000 Subject: [PATCH] fix(cli): correct os-doctor claim in --confirm-global-uniques comment The justification comment for `--confirm-global-uniques` claimed `os doctor` "can later show who affirmed it and when". Measured against `os doctor` (packages/cli/src/commands/doctor.ts) and `unconfirmedGlobalUniques` (packages/types/src/unique-scope-install-gate.ts), that is not what happens: doctor reads the attestation only to subtract already-answered findings from its advisory, using `attestation.posture` and `attestation.confirmed`. Nothing reads `attestedAt` / `attestedBy` anywhere in the repo outside of the declaration/writer and their own unit tests (verified with a repo-wide grep for both field names). Reworded the comment to describe the measured suppression behaviour, while preserving the two things it got right: the flag is deliberately not default-on, and deliberately not named `--force`, because it records an affirmative fact rather than overriding a check. Fixes #9022 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01Y26DJEHSBhhAQ6wwfsHNza --- packages/cli/src/commands/package/install.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/cli/src/commands/package/install.ts b/packages/cli/src/commands/package/install.ts index b47f285b4e..81a923e668 100644 --- a/packages/cli/src/commands/package/install.ts +++ b/packages/cli/src/commands/package/install.ts @@ -74,8 +74,12 @@ export default class PackageInstall extends Command { // [ADR-0120 D5e] The installer's answer to the `isolated`-posture question. // Deliberately NOT default-on and deliberately not named `--force`: it // records an affirmative fact ("these constraints are genuinely - // platform-wide") into the install manifest, where `os doctor` can later - // show who affirmed it and when. + // platform-wide") into the install manifest, rather than overriding a + // check. `os doctor` reads that record back on every later run, but only + // to SUPPRESS re-reporting the constraints this ceremony already answered + // for (`unconfirmedGlobalUniques` in `@objectstack/types`) — an attested + // install does not become the recurring nag the gate exists to avoid. It + // does not display who affirmed it or when. 'confirm-global-uniques': Flags.boolean({ description: "Confirm this app's installation-wide (`unique: 'global'`) constraints are genuinely platform-wide when "